Skip to main content
Skip table of contents

Vets API PR tips

Last Updated: May 23, 2025

This page explains when a PR is ready for Backend Platform review and lists common issues that can delay approval.

When is a Vets API PR ready for Platform review?

Before a backend Platform engineer reviews your PR, please make sure the following are complete:

  • The tests, linting, and settings validations CI checks are passing

  • At least one teammate has reviewed and approved the PR

Once those are in place, a backend engineer on support will review your PR–typically within one business day, but please allow up to three days per our documentation.

Set your PR up for success

Backend Platform engineers often catch things a teammate might have missed–and vice versa. Here are some tips from the Platform perspective to help your PR avoid delays:

  • Mock flippers in tests–don’t directly enable or disable flippers in tests. See documentation for examples.

  • Ensure PII is NOT getting exposed (in logs, URLs, VCR cassettes, etc.). PII-related documentation here.

  • Teammate comments are answered.

  • There are new or updated specs to go along with a code change and/or testing steps in the PR description.

  • PR description is filled out (link the related issue and a screenshot if the issue is in Jira).

  • Your branch is fresh (updated within 24 hours should be sufficient).

  • Migrations follow these best practices.

  • Avoid disabling Rubocop rules, unless necessary.


JavaScript errors detected

Please note, these errors can depend on your browser setup.

If this problem persists, please contact our support.