Developer docs
Developer docs
Breadcrumbs

Vets API PR tips

Last Updated: August 13, 2026

This page explains when a PR is ready for Backend Platform review and lists common issues that can delay approval.

When is a Vets API PR ready for Platform review?

Before a backend Platform engineer reviews your PR, please make sure the following are complete:

  • The tests, linting, and settings validations CI checks are passing

  • No merge conflicts

  • At least one teammate has reviewed and approved the PR

Once those are in place, a backend engineer on support will review your PR–typically within one business day, but please allow up to three days per our documentation.

Note: The 3 business day clock starts after all the requirements have been satisfied. We cannot guarantee a PR can be pushed through due to lack of planning.

Set your PR up for success

Backend Platform engineers often catch things a teammate might have missed–and vice versa. Here are some tips from the Platform perspective to help your PR avoid delays:

  • Ensure PII is NOT getting exposed (in logs, URLs, VCR cassettes, etc.). PII-related documentation here.

  • Teammate comments are answered.

  • Copilot comments are addressed and resolved. (Please verify Copilot comments are valid.)

  • There are new or updated specs to go along with a code change and/or testing steps in the PR description.

  • PR description is filled out (link the related issue and a screenshot if the issue is in Jira).

  • Your branch is fresh (updated within 24 hours should be sufficient).

  • Migrations follow these best practices.

  • Avoid disabling Rubocop rules, unless necessary.

  • use require-backend-approval GitHub label to add a second way to get your PR in the queue.

Help and feedback